Skip to content

FORMS-15466 Fixing conflicting vault filter#1326

Merged
rismehta merged 1 commit intodevfrom
vault
Jul 22, 2024
Merged

FORMS-15466 Fixing conflicting vault filter#1326
rismehta merged 1 commit intodevfrom
vault

Conversation

@rismehta
Copy link
Copy Markdown
Collaborator

@rismehta rismehta commented Jul 22, 2024

@review @vdua
DOD(Yes)

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

@rismehta rismehta mentioned this pull request Jul 22, 2024
Closed
@adobe-bot
Copy link
Copy Markdown

adobe-bot commented Jul 22, 2024

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 92 96 96 75

@adobe-bot
Copy link
Copy Markdown

adobe-bot commented Jul 22, 2024

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 96 75

@adobe-bot
Copy link
Copy Markdown

adobe-bot commented Jul 22, 2024

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

2 similar comments
@adobe-bot
Copy link
Copy Markdown

adobe-bot commented Jul 22, 2024

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

@adobe-bot
Copy link
Copy Markdown

adobe-bot commented Jul 22, 2024

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.73%. Comparing base (41e4b47) to head (d49fcce).

Additional details and impacted files 
@@            Coverage Diff            @@
##                dev    #1326   +/-   ##
=========================================
  Coverage     81.73%   81.73%           
  Complexity      853      853           
=========================================
  Files            97       97           
  Lines          2267     2267           
  Branches        305      305           
=========================================
  Hits           1853     1853           
  Misses          255      255           
  Partials        159      159

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rismehta rismehta merged commit 231a14a into dev Jul 22, 2024
@rismehta rismehta deleted the vault branch July 22, 2024 09:20
@nit23uec
Copy link
Copy Markdown
Collaborator

nit23uec commented Jul 22, 2024

pls avoid referencing internal jira issues in public.

@rismehta
Copy link
Copy Markdown
Collaborator Author

rismehta commented Jul 23, 2024 •
edited
Loading

pls avoid referencing internal jira issues in public.

Referring to internal JIRA IDs in GitHub repositories is a practice we have consistently followed. However, we avoid including internal Adobe VPN links in commit messages. Including JIRA ID's can enhance traceability and make it easier to track issues and changes over time.

This practice is also implemented in other Adobe GitHub projects, such as in this example: adobe/aem-core-wcm-components#2804
https://github.com/adobe/aem-core-wcm-components/releases/tag/core.wcm.components.reactor-2.25.0

In some instances, if a GitHub issue is logged, so you won't find a corresponding JIRA ticket.

pavi41 pushed a commit that referenced this pull request Jul 24, 2024
@rismehta
FORMS-15466 Fixing conflicting vault filter (#1326)
0c14f5c 
@review @vdua
DOD(Yes)
dmaurya929 pushed a commit that referenced this pull request Jul 24, 2024
@rismehta @dmaurya929
FORMS-15466 Fixing conflicting vault filter (#1326)
2a388c7 
@review @vdua
DOD(Yes)
rismehta added a commit that referenced this pull request Jul 25, 2024
@rismehta
FORMS-15466 Fixing conflicting vault filter (#1326)
1f83a01 
@review @vdua
DOD(Yes)
rismehta added a commit that referenced this pull request Jul 25, 2024
@rismehta
FORMS-15466 Fixing conflicting vault filter (#1326)
6725fab 
@review @vdua
DOD(Yes)
@rismehta rismehta mentioned this pull request Jul 26, 2024
Merged
10 tasks
@shravanthprasad shravanthprasad mentioned this pull request Sep 9, 2024
Closed
barshat7 pushed a commit that referenced this pull request Sep 13, 2024
@rismehta
FORMS-15466 Fixing conflicting vault filter (#1326)
a53458d 
@review @vdua
DOD(Yes)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rismehta @adobe-bot @nit23uec